Explicitly confirm or rollback Touch ID registrations #13220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
force-pushed
the
codingllama/touchid-register2
branch
from
1b50c79 to
fad3fab
Compare
github-actions
bot
added
the
tsh
zmb3
approved these changes
Jun 7, 2022
|
Friendly ping @ibeckermayer @nklaassen ? |
codingllama
force-pushed
the
codingllama/touchid-register2
branch
from
fad3fab to
d73804f
Compare
|
Friendly ping @ibeckermayer @nklaassen? I'd like this to land for v10. |
nklaassen
approved these changes
Jun 8, 2022
codingllama
force-pushed
the
codingllama/touchid-register2
branch
from
d73804f to
965801c
Compare
codingllama
force-pushed
the
codingllama/touchid-register2
branch
4 times, most recently
from
dabe267 to
19f10f7
Compare
codingllama
force-pushed
the
codingllama/touchid-register2
branch
from
19f10f7 to
990351d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Touch ID registration interface so
tshexplicitly confirms or rollbacks MFA registrations.Before resident keys, MFA keys from U2F or WebAuthn only truly existed server-side, but with resident keys/passwordless some cleanup is necessary if the server-side registration goes awry.
The PR also changes Touch ID authentication so that newer keys are preferred, which allows re-registration to be used as sort of a self-healing mechanism.
#9160