Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3:AbortMultipartUpload to AWS IAM policies #13213

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

webvictim
Copy link
Contributor

Searched for all locations where s3:ListBucketMultipartUploads is currently required and added it. This includes:

  • Example S3 IAM policy in AWS Helm guide
  • CloudFormation (although this isn't really maintained or supported)
  • Terraform

It looks like this was an oversight when #10608 was merged initially.

Searched for all locations where s3:ListBucketMultipartUploads is currently required and added it.
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now, but I wonder if we should make a variable or something with all the required permissions so there's only 1 source of truth and less chance to miss a spot in the future.

@ptgott any suggestions for how we might do that?

@webvictim webvictim changed the title Add S3:AbortMultipartUploads to AWS IAM policies Add S3:AbortMultipartUpload to AWS IAM policies Jun 6, 2022
@webvictim
Copy link
Contributor Author

AFAICT this only actually appears in the docs once, the rest is in Terraform/Cloudformation.

@webvictim webvictim enabled auto-merge (squash) June 6, 2022 18:51
@webvictim webvictim merged commit 252ca62 into master Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

@webvictim See the table below for backport results.

Branch Result
branch/v7 Create PR
branch/v8 Create PR
branch/v9 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants