Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh to use new 'teleport node configure' command #13127

Merged
merged 9 commits into from
Jun 8, 2022

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Jun 2, 2022

No description provided.

@github-actions github-actions bot requested review from greedy52 and timothyb89 June 2, 2022 20:35
@hatched hatched marked this pull request as draft June 2, 2022 20:47
@hatched hatched marked this pull request as ready for review June 7, 2022 15:18
@github-actions github-actions bot requested a review from ravicious June 7, 2022 15:18
@@ -318,6 +318,7 @@ func Run(options Options) (app *kingpin.Application, executedCommand string, con
dumpNodeConfigure.Flag("token", "Invitation token to register with an auth server.").StringVar(&dumpFlags.AuthToken)
dumpNodeConfigure.Flag("auth-server", "Address of the auth server.").StringVar(&dumpFlags.AuthServer)
dumpNodeConfigure.Flag("labels", "Comma-separated list of labels to add to newly created nodes ex) env=staging,cloud=aws.").StringVar(&dumpFlags.NodeLabels)
dumpNodeConfigure.Flag("ca-pins", "Comma-separated list of SKPI hashes for the CA used to verify the auth server.").StringVar(&dumpFlags.CAPin)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's technically 1 or more pins, but all of our other CLI tools use --ca-pin so I think it would be best to be consistent, even if slightly inaccurate.

@hatched hatched enabled auto-merge (squash) June 8, 2022 16:11
@hatched hatched merged commit abe5874 into master Jun 8, 2022
@zmb3 zmb3 deleted the hatched/join-install branch August 12, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants