Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore HTTP_PROXY for multi-port mode #13048

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Conversation

atburke
Copy link
Contributor

@atburke atburke commented May 31, 2022

This PR undoes the changes in #11990 and #12335 for Teleport going forward.

Fixes #12215.

Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but this should include an accompanying documentation change/note that explains how to ignore HTTP_PROXY for tunnel connections, since it requires adding kube.teleport.cluster.local (or something like that) to NO_PROXY?

@r0mant
Copy link
Collaborator

r0mant commented Jun 2, 2022

lgtm but this should include an accompanying documentation change/note that explains how to ignore HTTP_PROXY for tunnel connections, since it requires adding kube.teleport.cluster.local (or something like that) to NO_PROXY?

@atburke Also to follow up on this, is this something we can handle in the code too? Detect that proxy is setup and print a hint in the error message if the request fails? We can do it in a follow up PR.

@atburke atburke merged commit 22c0fcc into master Jun 7, 2022
@atburke atburke deleted the atburke/restore-http-proxy branch June 7, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore support for SSH reverse tunnel connection through HTTP CONNECT proxy
3 participants