Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add PAM build tag back to tctl build #12570

Merged
merged 1 commit into from
May 11, 2022

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented May 11, 2022

Fixes #12547

I'm not sure if this is the best solution, but it fixes the bug for now. It may be difficult to fix this otherwise as tctl loads the main teleport config which checks for the inclusion of pam when configured, even if tctl itself may not leverage it.

Partially undoes #11666

We will need to ensure we backport this into the versions that the original PR was backported into.

@ravicious
Copy link
Member

ravicious commented May 11, 2022

#11666 was an attempt to tackle some problems with building tsh on Windows (we had a conversation about it on Slack). The actual problem lied somewhere else: code in tsh imported code from lib/web, which is supposed to be imported by the teleport binary only. Since lib/web assumes that it runs on a unix-like system, there were problems with building tsh on Windows. This has been fixed in #11690.

Still, at the time we decided to clean up those tags since we deemed them unnecessary, we weren't aware that it may cause problems with tctl. So adding PAM to tctl back shouldn't make the original issue with tsh builds on Windows reoccur.

@ravicious
Copy link
Member

Ah, and the original PR was backported to the v9 branch only, I added an appropriate label to this PR.

@strideynet strideynet merged commit 3fd2277 into master May 11, 2022
@strideynet strideynet deleted the strideynet/add-pam-build-tag-tctl branch May 11, 2022 13:40
@strideynet strideynet restored the strideynet/add-pam-build-tag-tctl branch May 11, 2022 13:40
@github-actions
Copy link

@strideynet See the table below for backport results.

Branch Result
branch/v9 Create PR

@strideynet strideynet deleted the strideynet/add-pam-build-tag-tctl branch May 11, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tctl broken with PAM enabled
3 participants