Fix ProxyKube not reporting its readiness
#12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Apr 21, 2022
rosstimothy
approved these changes
Apr 21, 2022
zmb3
approved these changes
Apr 21, 2022
r0mant
added a commit
that referenced
this pull request
Apr 26, 2022
* Revert "Make `PortList.Pop()` thread-safe (#11799)" This reverts commit a17337d. * Revert "Ensure stateOK is reported only when all components have sent updates (#11249)" This reverts commit b749302. * Revert "Throw startup error if `TeleportReadyEvent` is not emitted (#11725)" This reverts commit 933e247. * Revert "Fix ProxyKube not reporting its readiness (#12150)" This reverts commit 6cdcfe7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11249 the
/readyzdiag endpoint will only report OK if enough components have heartbeated without error; however, theproxy.kubeservice will not actually heartbeat unless it's running in "legacy" mode, also acting as akubernetes_service. This PR makes it so that if that's the case, an initial OK heartbeat is reported for that component (similarly to what adb_servicewill do when running in dynamic mode with no configured databases).Fixes #12139.