Delete stale session trackers #11809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
reviewed
Apr 7, 2022
espadolini
reviewed
Apr 8, 2022
Co-authored-by: Edoardo Spadolini <[email protected]>
espadolini
approved these changes
Apr 8, 2022
Co-authored-by: Edoardo Spadolini <[email protected]>
Joerger
reviewed
Apr 8, 2022
Joerger
approved these changes
Apr 8, 2022
Co-authored-by: Brian Joerger <[email protected]>
codingllama
reviewed
Apr 11, 2022
Co-authored-by: Alan Parra <[email protected]>
codingllama
approved these changes
Apr 11, 2022
xacrimon
added a commit
that referenced
this pull request
Apr 12, 2022
xacrimon
added a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #11551 significantly improves expiry for future sessions, it still does not clean up old sessions. This PR checks for old expired sessions that do not have an item key expiry set upon fetching the tracker list and if found, deletes the tracker.