Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error message if supplied auth connector name doesn't match registered names. #11800

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Apr 7, 2022

If a supplied auth connector name does not match any of the registered names then return an error message with the possible valid connector names.

$ tsh --auth=Github login
ERROR: invalid connector name: Github; valid options: github, hatch

Fixes #11427

@github-actions github-actions bot requested review from atburke and timothyb89 April 7, 2022 15:08
@github-actions github-actions bot added the tsh tsh - Teleport's command line tool for logging into nodes running Teleport. label Apr 7, 2022
api/client/webclient/webclient.go Outdated Show resolved Hide resolved
api/client/webclient/webclient.go Outdated Show resolved Hide resolved
lib/web/apiserver.go Outdated Show resolved Hide resolved
@hatched hatched changed the title Hatched/connector 11427 Return error message if supplied auth connector name doesn't match registered names. Apr 7, 2022
@hatched hatched enabled auto-merge (squash) April 7, 2022 22:04
@hatched hatched merged commit c0a0a6c into master Apr 7, 2022
@hatched hatched deleted the hatched/connector-11427 branch April 7, 2022 22:29
@gravitational gravitational deleted a comment from tony-Rdz Apr 8, 2022
hatched added a commit that referenced this pull request Apr 11, 2022
…gistered names. (#11800)

* Include the possible connector values if supplied value is invalid.

* Update messaging for auth flag.

* Return error message from failed ping response.

* Collect the connector names in the existing loops.
hatched added a commit that referenced this pull request Apr 11, 2022
…gistered names. (#11800)

* Include the possible connector values if supplied value is invalid.

* Update messaging for auth flag.

* Return error message from failed ping response.

* Collect the connector names in the existing loops.
hatched added a commit that referenced this pull request Apr 11, 2022
…gistered names. (#11800)

* Include the possible connector values if supplied value is invalid.

* Update messaging for auth flag.

* Return error message from failed ping response.

* Collect the connector names in the existing loops.
hatched added a commit that referenced this pull request Apr 13, 2022
…gistered names. (#11800) (#11885)

* Include the possible connector values if supplied value is invalid.

* Update messaging for auth flag.

* Return error message from failed ping response.

* Collect the connector names in the existing loops.
hatched added a commit that referenced this pull request Apr 13, 2022
…gistered names. (#11800) (#11886)

* Include the possible connector values if supplied value is invalid.

* Update messaging for auth flag.

* Return error message from failed ping response.

* Collect the connector names in the existing loops.
hatched added a commit that referenced this pull request Apr 14, 2022
…gistered names. (#11800) (#11884)

* Include the possible connector values if supplied value is invalid.

* Update messaging for auth flag.

* Return error message from failed ping response.

* Collect the connector names in the existing loops.
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO connector name is case-sensitive
3 participants