Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Add hint when the user receives an error about an "unknown certificate authority" (#11550) #11751

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Apr 5, 2022

Backports #11550

  • Intercept and update error message when there is a certificate error joining a node.

  • Log out error hint and return full wrapped error.

  • Updated error message.

hatched and others added 2 commits April 5, 2022 15:45
…e authority" (#11550)

* Intercept and update error message when there is a certificate error joining a node.

* Log out error hint and return full wrapped error.

* Updated error message.
@github-actions github-actions bot requested review from Tener, timothyb89 and zmb3 April 5, 2022 21:46
@zmb3
Copy link
Collaborator

zmb3 commented Apr 5, 2022

@hatched I just realized that hard-coding /var/lib/teleport in the error message is probably not the best idea, since it will confuse users who have configured a different data directory.

Do you want to fix it in master and leave these backport PRs open so you can pull the fix in without needing a second set of backports?

lib/service/connect.go Outdated Show resolved Hide resolved
@hatched hatched enabled auto-merge (squash) April 6, 2022 15:39
@hatched hatched merged commit 069bb9a into branch/v9 Apr 6, 2022
@hatched hatched deleted the hatched/backport-11550-v9 branch April 6, 2022 16:19
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants