Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Okta OIDC #11718

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix Okta OIDC #11718

merged 1 commit into from
Apr 13, 2022

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Apr 4, 2022

Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()

lib/auth/oidc.go Show resolved Hide resolved
@zmb3 zmb3 added the release-notes A reminder label to into the release notes of the Teleport Release. label Apr 4, 2022
@zmb3
Copy link
Collaborator Author

zmb3 commented Apr 4, 2022

For release notes:

This fixes the following error when attempting to use Okta as an OIDC provider: token_endpoint_auth_signing_alg_values_supported cannot include 'none'

go.mod Show resolved Hide resolved
lib/auth/oidc.go Show resolved Hide resolved
lib/auth/oidc.go Outdated Show resolved Hide resolved
@zmb3
Copy link
Collaborator Author

zmb3 commented Apr 13, 2022

@russjones in order to get Okta OIDC working you need this PR and you also need to set provider: ping.

Any objection to adding support for provider: okta? (It would do the same thing, just less confusing for Okta users)

@russjones
Copy link
Contributor

Yeah, add provider: okta if we need special handling for them.

I had to do something similar for JumpCloud: #11805

@zmb3 zmb3 force-pushed the zmb3/fix-okta-oidc branch from 4551f4c to f4aa4de Compare April 13, 2022 21:00
@zmb3 zmb3 enabled auto-merge (squash) April 13, 2022 21:04
@zmb3 zmb3 force-pushed the zmb3/fix-okta-oidc branch from f4aa4de to 966bae4 Compare April 13, 2022 21:37
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
@zmb3 zmb3 force-pushed the zmb3/fix-okta-oidc branch from 966bae4 to eeacf60 Compare April 13, 2022 22:25
@zmb3 zmb3 merged commit 87bb833 into master Apr 13, 2022
@zmb3 zmb3 deleted the zmb3/fix-okta-oidc branch April 13, 2022 22:59
zmb3 added a commit that referenced this pull request Apr 14, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 14, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 14, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 14, 2022
This is the docs counterpart to #11718
Gregy pushed a commit to Gregy/teleport that referenced this pull request Apr 14, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
* Document Okta OIDC provider workaround

This is the docs counterpart to #11718

* Update docs/pages/enterprise/sso.mdx

Co-authored-by: Paul Gottschling <[email protected]>

Co-authored-by: Paul Gottschling <[email protected]>
zmb3 added a commit that referenced this pull request Apr 15, 2022
* Document Okta OIDC provider workaround

This is the docs counterpart to #11718

* Update docs/pages/enterprise/sso.mdx

Co-authored-by: Paul Gottschling <[email protected]>

Co-authored-by: Paul Gottschling <[email protected]>
zmb3 added a commit that referenced this pull request Apr 15, 2022
* Document Okta OIDC provider workaround

This is the docs counterpart to #11718

* Update docs/pages/enterprise/sso.mdx

Co-authored-by: Paul Gottschling <[email protected]>

Co-authored-by: Paul Gottschling <[email protected]>
zmb3 added a commit that referenced this pull request Apr 15, 2022
* Document Okta OIDC provider workaround

This is the docs counterpart to #11718

* Update docs/pages/enterprise/sso.mdx

Co-authored-by: Paul Gottschling <[email protected]>

Co-authored-by: Paul Gottschling <[email protected]>
zmb3 added a commit that referenced this pull request Apr 15, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
Using the OIDC connector with Okta would fail due to an issue in our
fork of go-oidc. Update this dependency to get the fix.

Additionally, clean up the logic for syncing the connector
configuration, which was using a context.Context in order to implement
a timeout. This can be expressed in a simpler way with time.After()
zmb3 added a commit that referenced this pull request Apr 15, 2022
This is the docs counterpart to #11718

Backports #11948 

Co-authored-by: Paul Gottschling <[email protected]>
zmb3 added a commit that referenced this pull request Apr 15, 2022
This is the docs counterpart to #11718

Co-authored-by: Paul Gottschling <[email protected]>
zmb3 added a commit that referenced this pull request Apr 15, 2022
This is the docs counterpart to #11718

Co-authored-by: Paul Gottschling <[email protected]>
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-required release-notes A reminder label to into the release notes of the Teleport Release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants