Ensure Cache types.WatchKinds and proto.WatchEvents are in sync
#11692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted.
ravicious
approved these changes
Apr 5, 2022
|
friendly ping @r0mant |
r0mant
approved these changes
Apr 8, 2022
rosstimothy
added a commit
that referenced
this pull request
Apr 13, 2022
…11692) This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted. (cherry picked from commit f5d2542) # Conflicts: # api/client/streamwatcher.go # lib/auth/grpcserver.go
rosstimothy
added a commit
that referenced
this pull request
Apr 13, 2022
…11692) This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted. (cherry picked from commit f5d2542) # Conflicts: # lib/auth/grpcserver.go
rosstimothy
added a commit
that referenced
this pull request
Apr 13, 2022
…11692) This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted. (cherry picked from commit f5d2542)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
rosstimothy
added a commit
that referenced
this pull request
Apr 15, 2022
…11692) (#11927) This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted. (cherry picked from commit f5d2542)
rosstimothy
added a commit
that referenced
this pull request
Apr 18, 2022
…11692) (#11926) This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted. (cherry picked from commit f5d2542) # Conflicts: # lib/auth/grpcserver.go
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
…11692) (#11925) This adds a test, `TestCacheWatchKindExistsInEvents`, that ensures all `types.WatchKind` registered for all Cache components have a corresponding `proto.Event` defined. By doing this we can ensure that for a release there will be no `resource type X is not suppported` errors causing the Cache to be unhealthy. Unfortunately this does not prevent issues across releases which may have different resources being emitted. (cherry picked from commit f5d2542) # Conflicts: # api/client/streamwatcher.go # lib/auth/grpcserver.go
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test,
TestCacheWatchKindExistsInEvents, that ensuresall
types.WatchKindregistered for all Cache components have acorresponding
proto.Eventdefined. By doing this we can ensurethat for a release there will be no
resource type X is not suppportederrors causing the Cache to be unhealthy. Unfortunately this does not
prevent issues across releases which may have different resources being emitted.