Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teleport-plugin guides to reference docker images for downloads #11617

Merged
merged 17 commits into from
Apr 13, 2022

Conversation

logand22
Copy link
Contributor

This PR is a part of gravitational/teleport-plugins#438

This PR adds additional installation instructions for the plugin guides that includes docker images.

This PR does not adjust the plugin guides to be fully updated for docker. An issue can be created for this to ensure the correctness of the guides when using docker images.

Testing

Ran the docs locally using instructions in https://github.com/gravitational/docs and confirmed that formatting was correct.

@github-actions github-actions bot requested review from r0mant, xinding33 and zmb3 March 31, 2022 16:29
@logand22 logand22 requested review from kbence and removed request for r0mant, zmb3 and xinding33 March 31, 2022 16:29
@logand22 logand22 requested a review from ptgott April 1, 2022 21:46
@wadells wadells requested a review from xinding33 April 6, 2022 17:32
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to one guide that also apply to the other guides.

docs/config.json Outdated Show resolved Hide resolved
docs/config.json Outdated Show resolved Hide resolved
docs/pages/enterprise/workflow/ssh-approval-jira-cloud.mdx Outdated Show resolved Hide resolved
docs/pages/enterprise/workflow/ssh-approval-jira-cloud.mdx Outdated Show resolved Hide resolved
docs/pages/enterprise/workflow/ssh-approval-jira-cloud.mdx Outdated Show resolved Hide resolved
@logand22 logand22 requested a review from ptgott April 8, 2022 17:10
Copy link
Contributor

@kbence kbence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@logand22 logand22 enabled auto-merge (squash) April 12, 2022 22:27
@russjones
Copy link
Contributor

@ptgott Do you mind taking a look at this PR?

Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have the Docker images moved repositories? Each docker pull command returns a variation on the error,

Error response from daemon: manifest for quay.io/gravitational/teleport-plugin-event-handler:9.0.4 not found: manifest unknown: manifest unknown

@logand22 logand22 requested a review from ptgott April 13, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants