Spread out UploadCompleter load
#11590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
approved these changes
Mar 30, 2022
Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future.
rosstimothy
force-pushed
the
tross/upload_completed_fixes
branch
from
04c6c72 to
23bc102
Compare
zmb3
approved these changes
Apr 1, 2022
rosstimothy
added a commit
that referenced
this pull request
Apr 4, 2022
* Spread out UploadCompleter load Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future. (cherry picked from commit d3de6c4) # Conflicts: # lib/events/complete.go
This was referenced Apr 4, 2022
rosstimothy
added a commit
that referenced
this pull request
Apr 4, 2022
* Spread out UploadCompleter load Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future. (cherry picked from commit d3de6c4) # Conflicts: # lib/events/complete.go
rosstimothy
added a commit
that referenced
this pull request
Apr 4, 2022
* Spread out UploadCompleter load Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future. (cherry picked from commit d3de6c4)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
rosstimothy
added a commit
that referenced
this pull request
Apr 5, 2022
* Spread out UploadCompleter load Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future. (cherry picked from commit d3de6c4)
rosstimothy
added a commit
that referenced
this pull request
Apr 5, 2022
* Spread out UploadCompleter load Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future. (cherry picked from commit d3de6c4)
rosstimothy
added a commit
that referenced
this pull request
Apr 5, 2022
* Spread out UploadCompleter load Replaces the use of a `Ticker` with an `Interval` to reduce the chance of auth servers `UploadCompleter` from synchronizing `run` loops. Without this auth servers are essentially racing against each other to upload any unfinished uploads. This was causing an increase in network utilization every 10 mins. This also prevents any missing parts of an upload from prematurely ending the unfinished upload process. Doing so only causes a back log of uploads that will never be completed during any of the subsequent calls to `CheckUploads` in the future. (cherry picked from commit d3de6c4)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the use of a
Tickerwith anIntervalto reduce thechance of auth servers
UploadCompleterfrom synchronizingrunloops. Without this auth servers are essentially racing against
each other to upload any unfinished uploads. This was causing
an increase in network utilization every 10 mins.
This also prevents any missing parts of an upload from prematurely
ending the unfinished upload process. Doing so only causes a back
log of uploads that will never be completed during any of the
subsequent calls to
CheckUploadsin the future.