teleport-cluster chart: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) #11493

johanneskastl · 2022-03-28T07:47:25Z

In standalone mode a PVC is created. The volume cannot be attached to more than one pod (depending on the storage available), so using a Recreate strategy is needed to avoid stuck deployments on upgrades.

webvictim · 2022-03-28T14:35:14Z

Hey @johanneskastl - thanks for the PR. Please take a look at https://github.com/gravitational/teleport/blob/master/examples/chart/CONTRIBUTING.md for some additional testing we'd need.

johanneskastl · 2022-03-30T13:12:19Z

Hey @johanneskastl - thanks for the PR. Please take a look at https://github.com/gravitational/teleport/blob/master/examples/chart/CONTRIBUTING.md for some additional testing we'd need.

Thanks for the hint @webvictim! I have added a test to tests/deployment_test.yaml that verifies that it sets the strategy in standalone mode. Do you recommend adding more tests?

Did I miss any other steps?

webvictim

@johanneskastl Thanks! Looks great!

Just one final ask: could you also please add three extra tests to make sure that the strategy is not set (so will default to RollingUpdate) for the other modes (aws, gcp and custom)?

Something similar to this section: https://github.com/gravitational/teleport/blob/master/examples/chart/teleport-cluster/tests/deployment_test.yaml#L234-L310 - you should be able to use the same values files.

examples/chart/teleport-cluster/templates/deployment.yaml

johanneskastl · 2022-03-31T07:02:45Z

Hey @webvictim, I added three more tests for AWS/GCP/Custom mode to not contain the strategy setting. Could you have a look if this is fine? Anything else missing?

Should I also commit this file that was created by running make lint-helm test-helm?

examples/chart/teleport-cluster/tests/__snapshot__/deployment_test.yaml.snap

dirien

Hi @johanneskastl,

that looks good for me! Looking forward for this PR as it blocks us too currently.

zmb3 · 2022-03-31T19:31:11Z

Looks good to me @johanneskastl - we just need to commit the examples/chart/teleport-cluster/tests/__snapshot__/deployment_test.yaml.snap and we should be good to merge this.

Thanks for the contribution!

webvictim

LGTM. As @zmb3 says, please commit the snapshot and we'll be good to go!

webvictim · 2022-04-01T02:45:10Z

/gcbrun

johanneskastl · 2022-04-01T06:50:59Z

@webvictim @zmb3 I commited the file, please have a look.

johanneskastl · 2022-04-02T11:43:59Z

Rebased on current master and solved conflict in examples/chart/teleport-cluster/tests/__snapshot__/deployment_test.yaml.snap.

Can this be merged? Or is something missing?

webvictim · 2022-04-02T12:28:16Z

/gcbrun

…gy to 'Recreate' if chartMode is 'standalone' (fixes gravitational#11484) Signed-off-by: Johannes Kastl <[email protected]>

…for strategy in standalone mode Signed-off-by: Johannes Kastl <[email protected]>

…test.yaml.snap after running local tests

johanneskastl · 2022-04-03T14:29:11Z

@webvictim I'll stop rebasing this, as I cannot run the tests anyway.

Please ping me if I can assists or if fixes are needed.

webvictim · 2022-04-03T14:32:30Z

@johanneskastl Thanks - I'm sure it's fine, we'll take a look when people are back at work on Monday.

webvictim · 2022-04-03T14:32:47Z

/gcbrun

webvictim · 2022-04-04T01:38:46Z

/gcbrun

webvictim · 2022-04-04T14:03:26Z

It looks like the review bot is refusing to approve this because reasons. I'll open a new buddy PR and get it merged.

johanneskastl · 2022-04-04T14:07:36Z

It looks like the review bot is refusing to approve this because reasons. I'll open a new buddy PR and get it merged.

Thanks @webvictim

* examples/chart/teleport-cluster/templates/deployment.yaml: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) Signed-off-by: Johannes Kastl <[email protected]> * examples/chart/teleport-cluster/tests/deployment_test.yaml: add test for strategy in standalone mode Signed-off-by: Johannes Kastl <[email protected]> * update examples/chart/teleport-cluster/tests/__snapshot__/deployment_test.yaml.snap after running local tests Co-authored-by: Johannes Kastl <[email protected]>

johanneskastl · 2022-04-05T08:11:45Z

@webvictim I see you merged 11693 containing my changes, so can we close this one?

webvictim · 2022-04-05T13:59:20Z

@johanneskastl Thanks for the contribution!

* examples/chart/teleport-cluster/templates/deployment.yaml: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) Signed-off-by: Johannes Kastl <[email protected]> * examples/chart/teleport-cluster/tests/deployment_test.yaml: add test for strategy in standalone mode Signed-off-by: Johannes Kastl <[email protected]> * update examples/chart/teleport-cluster/tests/__snapshot__/deployment_test.yaml.snap after running local tests Co-authored-by: Johannes Kastl <[email protected]>

* helm: Buddy merge for #11493 (#11693) * examples/chart/teleport-cluster/templates/deployment.yaml: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) Signed-off-by: Johannes Kastl <[email protected]> * examples/chart/teleport-cluster/tests/deployment_test.yaml: add test for strategy in standalone mode Signed-off-by: Johannes Kastl <[email protected]> * update examples/chart/teleport-cluster/tests/__snapshot__/deployment_test.yaml.snap after running local tests Co-authored-by: Johannes Kastl <[email protected]> * helm: Allow probe timeouts to be configurable (buddy merge of #11176) (#11396) * Allow for probe timeouts to be configurable When setting up a new Teleport enterprise cluster on GCP, I noticed that I needed to set the probe timeouts to get the cluster to be healthy. This seems to be a known issue (kubernetes/kubernetes#89898). As a "stopgap", I've updated the helm chart to allow for end users to be able to configure these timeouts. * Update configuration option name and add documentation * Update docs/pages/kubernetes-access/helm/reference.mdx Co-authored-by: Gus Luxton <[email protected]> * Add tests for probeTimeoutSeconds * Add probeTimeoutSeconds to required values * Add probeTimeoutSeconds to teleport-kube-agent * Add tests for probeTimeoutSeconds to teleport-kube-agent * Add probeTimeoutSeconds to teleport-kube-agent reference Co-authored-by: Hunter Madison <[email protected]> Co-authored-by: Hunter Madison <[email protected]> Co-authored-by: Johannes Kastl <[email protected]> Co-authored-by: Hunter Madison <[email protected]> Co-authored-by: Hunter Madison <[email protected]>

github-actions bot added the helm label Mar 28, 2022

github-actions bot requested review from r0mant and zmb3 March 28, 2022 07:47

johanneskastl mentioned this pull request Mar 28, 2022

Helm chart teleport-cluster: "Multi-Attach error for volume" when upgrading via "helm upgrade" #11484

Closed

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch from cb61471 to 35af5b8 Compare March 30, 2022 13:09

webvictim reviewed Mar 30, 2022

View reviewed changes

examples/chart/teleport-cluster/templates/deployment.yaml Outdated Show resolved Hide resolved

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch from 35af5b8 to f828785 Compare March 31, 2022 07:01

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch 2 times, most recently from 14f97df to 8a2df42 Compare March 31, 2022 07:16

dirien approved these changes Mar 31, 2022

View reviewed changes

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch from 8a2df42 to 49fb486 Compare March 31, 2022 19:08

webvictim reviewed Mar 31, 2022

View reviewed changes

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch from 81dcc3a to f1b293d Compare April 1, 2022 06:49

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch 2 times, most recently from 23b1138 to 2f7c4b9 Compare April 1, 2022 17:41

zmb3 approved these changes Apr 1, 2022

View reviewed changes

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch 3 times, most recently from f0fa0c5 to de1ec3c Compare April 2, 2022 11:43

Johannes Kastl added 3 commits April 3, 2022 10:03

examples/chart/teleport-cluster/templates/deployment.yaml: set strate…

a6f50ea

…gy to 'Recreate' if chartMode is 'standalone' (fixes gravitational#11484) Signed-off-by: Johannes Kastl <[email protected]>

examples/chart/teleport-cluster/tests/deployment_test.yaml: add test …

44a276f

…for strategy in standalone mode Signed-off-by: Johannes Kastl <[email protected]>

update examples/chart/teleport-cluster/tests/__snapshot__/deployment_…

db1640d

…test.yaml.snap after running local tests

johanneskastl force-pushed the 20220328_helm_chart_strategy_recreate branch from de1ec3c to db1640d Compare April 3, 2022 09:00

Merge branch 'master' into 20220328_helm_chart_strategy_recreate

ce7d9f5

webvictim enabled auto-merge (squash) April 4, 2022 01:39

webvictim approved these changes Apr 4, 2022

View reviewed changes

webvictim added the backport-required label Apr 4, 2022

webvictim mentioned this pull request Apr 4, 2022

helm: Buddy merge for #11493 #11693

Merged

webvictim closed this Apr 5, 2022

auto-merge was automatically disabled April 5, 2022 13:59
Pull request was closed

webvictim removed the backport-required label Apr 13, 2022

johanneskastl deleted the 20220328_helm_chart_strategy_recreate branch April 16, 2022 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

teleport-cluster chart: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) #11493

teleport-cluster chart: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) #11493

johanneskastl commented Mar 28, 2022

webvictim commented Mar 28, 2022

johanneskastl commented Mar 30, 2022

webvictim left a comment

johanneskastl commented Mar 31, 2022 •

edited

Loading

dirien left a comment

zmb3 commented Mar 31, 2022

webvictim left a comment

webvictim commented Apr 1, 2022

johanneskastl commented Apr 1, 2022

johanneskastl commented Apr 2, 2022

webvictim commented Apr 2, 2022

johanneskastl commented Apr 3, 2022

webvictim commented Apr 3, 2022

webvictim commented Apr 3, 2022

webvictim commented Apr 4, 2022

webvictim commented Apr 4, 2022

johanneskastl commented Apr 4, 2022

johanneskastl commented Apr 5, 2022

webvictim commented Apr 5, 2022

teleport-cluster chart: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) #11493

teleport-cluster chart: set strategy to 'Recreate' if chartMode is 'standalone' (fixes #11484) #11493

Conversation

johanneskastl commented Mar 28, 2022

webvictim commented Mar 28, 2022

johanneskastl commented Mar 30, 2022

webvictim left a comment

Choose a reason for hiding this comment

johanneskastl commented Mar 31, 2022 • edited Loading

dirien left a comment

Choose a reason for hiding this comment

zmb3 commented Mar 31, 2022

webvictim left a comment

Choose a reason for hiding this comment

webvictim commented Apr 1, 2022

johanneskastl commented Apr 1, 2022

johanneskastl commented Apr 2, 2022

webvictim commented Apr 2, 2022

johanneskastl commented Apr 3, 2022

webvictim commented Apr 3, 2022

webvictim commented Apr 3, 2022

webvictim commented Apr 4, 2022

webvictim commented Apr 4, 2022

johanneskastl commented Apr 4, 2022

johanneskastl commented Apr 5, 2022

webvictim commented Apr 5, 2022

johanneskastl commented Mar 31, 2022 •

edited

Loading