Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] Split the Helm chart reference #11441

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Mar 24, 2022

Backports #11292

This will make it easier to navigate to different values settings for
each chart, since values can have their own H2 sections that are
distinct from chart names. (Previously, both chart names and values
settings were organized into H2 section headings.)

This will also mean that edition warnings for Cloud users can be more
visible, since we can place them at the top of a page for a given chart.

See #10636

Copy link
Contributor

@webvictim webvictim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are failing though.

@ptgott ptgott force-pushed the paul.gottschling/11292-bp-v8 branch from b348cc5 to 369c938 Compare March 28, 2022 20:09
Backports #11292

This will make it easier to navigate to different values settings for
each chart, since values can have their own H2 sections that are
distinct from chart names. (Previously, both chart names and values
settings were organized into H2 section headings.)

This will also mean that edition warnings for Cloud users can be more
visible, since we can place them at the top of a page for a given chart.

See #10636
@ptgott ptgott force-pushed the paul.gottschling/11292-bp-v8 branch from 369c938 to ea2dce7 Compare March 30, 2022 20:22
@ptgott ptgott enabled auto-merge (squash) March 30, 2022 20:22
@ptgott ptgott merged commit 2f0a6a1 into branch/v8 Mar 30, 2022
@ptgott ptgott deleted the paul.gottschling/11292-bp-v8 branch March 30, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants