Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document limitations with the Google OIDC connector and transitive group memberships #11422

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

espadolini
Copy link
Contributor

Closes #10635, albeit unsatisfactorily.

Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why this note should have the starting/ending point that it does. I think it would be clearer to break the "Configuring Google Workspace" H2 into H3-level sections.

The first could be a "Configure Google group permissions" (or similar) section that rephrases the the six paragraphs after the "Configuring Google Workspace" heading into a set of instructions.

Then we can change each bullet point into an H3-level heading so this organization is clearer. For example, the "Create a new project" bullet would instead be a "### Create a new project" H3 heading, then the first line in that section would be a sentence saying, "Next, create a new project."

What do you think? I'm also happy to implement this suggestions as a PR against your branch if that's easier for you.

@@ -54,6 +54,22 @@ fetching just the groups with direct membership is also supported. The preferred
behavior is selected depending on the OAuth scopes granted to the service
account associated with the connector.

<Admonition type="note">
Because of an inherent limitation in Google APIs, fetching transitive groups
requires view permissions on all transitive groups that users belong to; as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires view permissions on all transitive groups that users belong to; as
requires view permissions on all transitive groups that users belong to. As

@espadolini
Copy link
Contributor Author

The initial part of "Configuring Google Workspace" is currently also acting as an implicit "choose which mode of operation you want" step; it would be better if we made it more explicit - especially if we also tied it into the "upgrade" instructions that are currently kind of awkwardly placed at the end of "Create an OIDC connector".

Given my mediocre technical writing skills we'd probably be better off if you implemented those changes - feel free to just push to this PR rather than opening up a new one about it, my only goal was to have something documented about this weird behavior that we've discovered before more customers stumble upon it inadvertently, but from what I've seen, configuring the google workspace connector is still kind of a pain point so we should probably document it better.

Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as Paul's comments are addressed.

@ptgott ptgott force-pushed the espadolini/google-oidc-defeat branch 2 times, most recently from dd92937 to c240fb4 Compare April 5, 2022 19:12
- Organize the Google OIDC guide into steps. This required removing
  the header from the oidcauthentication.mdx partial.
- Use H3s for the "Configure Google Workspace" H2
- Add an explanation of the Workspace APIs
@ptgott ptgott force-pushed the espadolini/google-oidc-defeat branch from c240fb4 to c427742 Compare April 5, 2022 19:13
@ptgott ptgott requested a review from zmb3 April 5, 2022 19:14
@espadolini espadolini requested a review from ptgott April 6, 2022 08:40
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions, but this works for me!

docs/pages/enterprise/sso/google-workspace.mdx Outdated Show resolved Hide resolved
docs/pages/enterprise/sso/google-workspace.mdx Outdated Show resolved Hide resolved
@espadolini espadolini enabled auto-merge (squash) April 6, 2022 16:18
@espadolini espadolini merged commit dfa4701 into master Apr 6, 2022
@espadolini espadolini deleted the espadolini/google-oidc-defeat branch April 6, 2022 16:23
espadolini added a commit that referenced this pull request Apr 6, 2022
…oup memberships (#11422)

* Document limitations with Google OIDC

* Reorganize the Google OIDC API instructions

- Organize the Google OIDC guide into steps. This required removing
  the header from the oidcauthentication.mdx partial.
- Use H3s for the "Configure Google Workspace" H2
- Add an explanation of the Workspace APIs

* Fix inaccuracies

* PR suggestions

Co-authored-by: Paul Gottschling <[email protected]>
espadolini added a commit that referenced this pull request Apr 6, 2022
…oup memberships (#11422)

* Document limitations with Google OIDC

* Reorganize the Google OIDC API instructions

- Organize the Google OIDC guide into steps. This required removing
  the header from the oidcauthentication.mdx partial.
- Use H3s for the "Configure Google Workspace" H2
- Add an explanation of the Workspace APIs

* Fix inaccuracies

* PR suggestions

Co-authored-by: Paul Gottschling <[email protected]>
russjones pushed a commit that referenced this pull request Apr 6, 2022
…oup memberships (#11422)

* Document limitations with Google OIDC

* Reorganize the Google OIDC API instructions

- Organize the Google OIDC guide into steps. This required removing
  the header from the oidcauthentication.mdx partial.
- Use H3s for the "Configure Google Workspace" H2
- Add an explanation of the Workspace APIs

* Fix inaccuracies

* PR suggestions

Co-authored-by: Paul Gottschling <[email protected]>
russjones pushed a commit that referenced this pull request Apr 6, 2022
…oup memberships (#11422)

* Document limitations with Google OIDC

* Reorganize the Google OIDC API instructions

- Organize the Google OIDC guide into steps. This required removing
  the header from the oidcauthentication.mdx partial.
- Use H3s for the "Configure Google Workspace" H2
- Add an explanation of the Workspace APIs

* Fix inaccuracies

* PR suggestions

Co-authored-by: Paul Gottschling <[email protected]>
@webvictim webvictim mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants