NO_PROXY port support + special case for proxying via localhost #11403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimbishopp Can you please take a look too? |
jimbishopp
reviewed
Mar 28, 2022
r0mant
reviewed
Mar 29, 2022
api/client/proxy/proxy.go
Outdated
|
|
||
| // parse parses a URL. If the address does not have a scheme, it will prepend "http" and try. | ||
| func parse(addr string) (*url.URL, error) { | ||
| proxyurl, err := url.Parse(addr) |
There was a problem hiding this comment.
Some things about this function are still unclear to me:
proxyurlis still confusing because this function doesn't actually deal with proxy addresses now.- In which case
addrwill not have a scheme in it? - Shouldn't we default to
httpsif the scheme is empty? That would be a more secure default, no?
There was a problem hiding this comment.
Whether or not addr has a scheme depends on the caller; the existing proxy tests didn't have schemes, so I'm assuming that's a common and expected scenario.
The extra http:// is only there to help parse the url; parse doesn't assume http. GetProxyAddress handles the scheme-less URLs by checking https first, then http.
r0mant
approved these changes
Apr 1, 2022
atburke
added a commit
that referenced
this pull request
Apr 5, 2022
This change updates NO_PROXY handling to allow blocking specific host:port combinations, rather than just the host. It also adds a special case for downgrading requests to plain HTTP when --insecure is true and the request goes through a plain HTTP proxy at localhost (i.e. HTTP_PROXY=http://localhost).
atburke
added a commit
that referenced
this pull request
Apr 12, 2022
This change updates NO_PROXY handling to allow blocking specific host:port combinations, rather than just the host. It also adds a special case for downgrading requests to plain HTTP when --insecure is true and the request goes through a plain HTTP proxy at localhost (i.e. HTTP_PROXY=http://localhost).
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates NO_PROXY handling to allow blocking specific host:port combinations, rather than just the host. It also adds a special case for downgrading requests to plain HTTP when the following conditions are met:
--insecureis trueHTTP_PROXY=http://localhost)Resolves #10175.