Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust dependencies #11400

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Update Rust dependencies #11400

merged 3 commits into from
Mar 24, 2022

Conversation

xacrimon
Copy link
Contributor

We have a decent number of outdated Rust dependencies. Time to upgrade!
Ran through tests of our Rust code and it seems to work well.

@xacrimon xacrimon requested review from espadolini and zmb3 March 23, 2022 20:51
@github-actions github-actions bot requested review from rosstimothy and Tener March 23, 2022 20:51
zmb3
zmb3 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns on the RDP stuff, but I am not familiar with datalog and how to test it to know whether or not things still work.

@Tener
Copy link
Contributor

Tener commented Mar 24, 2022 •
edited
Loading

No concerns on the RDP stuff, but I am not familiar with datalog and how to test it to know whether or not things still work.

The datalog is behind tctl access ls code. We do have (conditionally compiled) tests for it: https://github.com/gravitational/teleport/blob/master/lib/datalog/access_test.go

@xacrimon xacrimon enabled auto-merge (squash) March 24, 2022 11:57
@xacrimon xacrimon merged commit 0bd0b23 into master Mar 24, 2022
@xacrimon xacrimon deleted the joel/update-rust-deps branch March 24, 2022 12:15
@zmb3
Copy link
Collaborator

zmb3 commented Mar 24, 2022

@xacrimon let's backport to v9 and v8 as well.

xacrimon added a commit that referenced this pull request Mar 24, 2022
@xacrimon
Update cargo deps (#11400)
77084b6
xacrimon added a commit that referenced this pull request Mar 24, 2022
@xacrimon
Update cargo deps (#11400)
baada08
This was referenced Mar 24, 2022
Merged
Merged
xacrimon added a commit that referenced this pull request Mar 24, 2022
@xacrimon
Update cargo deps (#11400) (#11416)
699fa9f
xacrimon added a commit that referenced this pull request Mar 24, 2022
@xacrimon
[branch/v8] Backport #11400 (#11415)
a4aa74d
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@espadolini espadolini espadolini approved these changes

Assignees
No one assigned
Labels
desktop-access rdp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xacrimon @Tener @zmb3 @espadolini