Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport v9] update e module #11341

Merged
merged 1 commit into from
Mar 22, 2022
Merged

[backport v9] update e module #11341

merged 1 commit into from
Mar 22, 2022

Conversation

rcanderson23
Copy link
Contributor

Update e to include build metric

@espadolini @timothyb89 this pulls in both of your commits so want to check with you that there isn't any issue there.

espadolini
espadolini approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My commit didn't require to be pulled in with any sort of rush, that's why I just left it there (reregistering the same marshaling function doesn't do anything, it just wastes a little bit of time).

@github-actions github-actions bot requested a review from xacrimon March 22, 2022 16:26
timothyb89
timothyb89 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@timothyb89 timothyb89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! That's probably an important one.

@rcanderson23 rcanderson23 merged commit a44ccd0 into branch/v9 Mar 22, 2022
@rcanderson23 rcanderson23 deleted the carson/v9/update-e-build-metric branch March 22, 2022 16:50
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyb89 timothyb89 timothyb89 approved these changes

@espadolini espadolini espadolini approved these changes

@xacrimon xacrimon Awaiting requested review from xacrimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcanderson23 @espadolini @timothyb89