Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9 backport] Add Cloud-specific instructions to two guides #11314

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Mar 21, 2022

Backports #10674

  • Add Cloud-specific instructions to two guides

Ensure that users of a particular scope don't see irrelevant info

See #10633

GitHub SSO guide

  • Edit the tctl partial to show only scope-relevant info.
  • Use tabs in the Prerequisites
  • Light edits for clarity

Adding Nodes

  • Use Tabs for prerequisites
  • Move sections specific to self-hosted deployments into Details
    boxes that are hidden for Cloud users
  • Use Tabs components to offer Cloud-specific alternatives to
    examples of commands that presuppose a self-hosted deployment
  • Misc clarity edits
  • Respond to PR feedback

  • Fix linter issues

Copy link
Contributor

@ulysseskan ulysseskan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a cloud perspective.

Backports #10674

* Add Cloud-specific instructions to two guides

Ensure that users of a particular scope don't see irrelevant info

See #10633

GitHub SSO guide
 - Edit the tctl partial to show only scope-relevant info.
 - Use tabs in the Prerequisites
 - Light edits for clarity

Adding Nodes
- Use Tabs for prerequisites
- Move sections specific to self-hosted deployments into Details
  boxes that are hidden for Cloud users
- Use Tabs components to offer Cloud-specific alternatives to
  examples of commands that presuppose a self-hosted deployment
- Misc clarity edits

* Respond to PR feedback

* Fix linter issues
@ptgott ptgott force-pushed the paul.gottschlinig/10674-bp-v9 branch from a050395 to e7262cb Compare March 22, 2022 18:32
@ptgott ptgott enabled auto-merge (squash) March 22, 2022 18:32
@ptgott ptgott merged commit 836fd7c into branch/v9 Mar 22, 2022
@ptgott ptgott deleted the paul.gottschlinig/10674-bp-v9 branch March 22, 2022 18:37
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants