Reexec with /proc/self/exe on Linux
#11283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/reexec-procfs
branch
3 times, most recently
from
5b6cc3c to
623b20e
Compare
nklaassen
reviewed
Mar 23, 2022
|
Yes, |
espadolini
force-pushed
the
espadolini/reexec-procfs
branch
2 times, most recently
from
ff6daf7 to
51a3765
Compare
nklaassen
previously approved these changes
Mar 24, 2022
espadolini
force-pushed
the
espadolini/reexec-procfs
branch
from
51a3765 to
b02107d
Compare
espadolini
force-pushed
the
espadolini/reexec-procfs
branch
3 times, most recently
from
8b7f9a4 to
bf35c15
Compare
espadolini
force-pushed
the
espadolini/reexec-procfs
branch
from
bf35c15 to
d68ff0b
Compare
|
@nklaassen @lxea PTAL, this should be the final version |
nklaassen
approved these changes
Mar 24, 2022
lxea
approved these changes
Mar 24, 2022
espadolini
added a commit
that referenced
this pull request
Mar 25, 2022
* Reexec with `/proc/self/exe` on Linux * Add a check for qemu-user * Add comment
espadolini
added a commit
that referenced
this pull request
Mar 25, 2022
* Reexec with `/proc/self/exe` on Linux * Add a check for qemu-user * Add comment
espadolini
added a commit
that referenced
this pull request
Mar 25, 2022
* Reexec with `/proc/self/exe` on Linux * Add a check for qemu-user * Add comment
This was referenced Mar 25, 2022
espadolini
added a commit
that referenced
this pull request
Mar 25, 2022
* Reexec with `/proc/self/exe` on Linux * Add a check for qemu-user * Add comment
espadolini
added a commit
that referenced
this pull request
Mar 25, 2022
* Reexec with `/proc/self/exe` on Linux * Add a check for qemu-user * Add comment
espadolini
added a commit
that referenced
this pull request
Mar 25, 2022
* Reexec with `/proc/self/exe` on Linux * Add a check for qemu-user * Add comment
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're using the output of
os.Executableto decide which binary to launch for our internalteleport exec/teleport forward/teleport checkhomedirreexecs. If the binary is replaced, for instance during an upgrade, we end up calling the new binary rather than the old one - which works fine but relies on the new version working correctly and having the exact semantics. If the binary is deleted (by accident, for instance) thetsh sshfunctionality breaks, which could be problematic if Teleport is the only way to remote into a system.We don't have a better way on Darwin, but on Linux (starting from Linux 2.2) running
execvedirectly on/proc/self/exewill execute the currently running binary no matter what happened to any paths referring to it. To compensate for a qemu-user bug (see https://gitlab.com/qemu-project/qemu/-/issues/927) and general qemu-user weirdness, we do a runtime check at init time to try to detect if we're in a qemu-user that is misbehaving, and if not, we end up opening our binary and then reexecuting it via/proc/self/fd/N.Closes #11052.