-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gosaml2
so it supports AES256GCM
#11272
Conversation
The change looks fine on its own, but I have questions:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @zmb3 for clarification regarding the original issue.
Nit: as mentioned, perhaps worth moving our fork to include latest additions to https://github.com/russellhaering/gosaml2.
Other than that, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If we want to update gosaml2 to the latest upstream commit, let's do that as a separate PR in case something breaks and we need to roll it back.
#11272 removed some required dependencies, this change brings them back
This change updates
gosaml2
to our fork with added support for AES256GCM and AES192GCM for encrypted assertions.I also run
go mod tidy
to cleanupgo.mod
fileCloses #10909
Note to reviewers: I'd ask for review of 2 things, this change and gravitational/gosaml2#4.
I moved
master
in fork to the commit we used before ingo.mod
(gravitational/gosaml2@757d23f) and started from there, you can check history at https://github.com/gravitational/gosaml2/commits/master