Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Improve tsh error message if mysql client is missing #11215

Merged
merged 2 commits into from
Mar 17, 2022
Merged

[v9] Improve tsh error message if mysql client is missing #11215

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e7671
Improve `tsh` error message if mysql client is missing (#11204)
jakule Mar 17, 2022
4759b6a
Merge branch 'branch/v9' into jakule/v9/tsh-mysql-msg
jakule Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tool/tsh/dbcmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ func (c *cliCommandBuilder) getMySQLCommand() (*exec.Cmd, error) {

// Check for mysql binary. Return with error as mysql and mariadb are missing. There is nothing else we can do here.
if !c.isMySQLBinAvailable() {
return nil, trace.NotFound("neither \"mysql\" nor \"mariadb\" were found")
return nil, trace.NotFound("neither %q nor %q CLI clients were found, please make sure an appropriate CLI client is available in $PATH", mysqlBin, mariadbBin)
}

// Check which flavor is installed. Otherwise, we don't know which ssl flag to use.
Expand Down