-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Helm installation instructions #11177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
force-pushed
the
paul.gottschling/10636-2
branch
from
March 16, 2022 14:54
a524557
to
cd0a238
Compare
zmb3
approved these changes
Mar 16, 2022
russjones
approved these changes
Mar 18, 2022
r0mant
approved these changes
Mar 18, 2022
ptgott
force-pushed
the
paul.gottschling/10636-2
branch
from
March 18, 2022 16:30
cd0a238
to
0b61bae
Compare
While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
force-pushed
the
paul.gottschling/10636-2
branch
from
March 18, 2022 16:43
0b61bae
to
a5b3f1d
Compare
ptgott
added a commit
that referenced
this pull request
Mar 21, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 21, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 21, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 22, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 22, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 22, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 23, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 23, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 23, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
ptgott
added a commit
that referenced
this pull request
Mar 23, 2022
Backports #11177 While addressing #10636, I noticed that the Details box that appears for Cloud users when they visit some of our Helm guides is in a slightly odd location, in the middle of a Prerequisites item. I have moved this to the top of each guide instead. I have also refactored the helm-install.mdx partial to split it into multiple partials, which allows us to use the "Step n/d" format in our Helm guides. Also adds a Cloud warning to the Digital Ocean Helm guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While addressing #10636, I noticed that the Details box that appears
for Cloud users when they visit some of our Helm guides is in a slightly
odd location, in the middle of a Prerequisites item. I have moved this to
the top of each guide instead.
I have also refactored the helm-install.mdx partial to split it into
multiple partials, which allows us to use the "Step n/d" format in our
Helm guides.