-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mention of max ttl for tctl tokens command #11148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 48h maximum is enforced for `tctl users add`, not `tctl tokens add`. Fixes #11137
github-actions
bot
requested review from
nklaassen,
ptgott,
r0mant,
ravicious and
xinding33
March 15, 2022 15:51
nklaassen
approved these changes
Mar 15, 2022
ptgott
approved these changes
Mar 15, 2022
ibeckermayer
approved these changes
Mar 15, 2022
zmb3
added a commit
that referenced
this pull request
Mar 15, 2022
The 48h maximum is enforced for `tctl users add`, not `tctl tokens add`. Fixes #11137
zmb3
added a commit
that referenced
this pull request
Mar 16, 2022
zmb3
added a commit
that referenced
this pull request
Mar 16, 2022
zmb3
added a commit
that referenced
this pull request
Mar 16, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 48h maximum is enforced for
tctl users add
,not
tctl tokens add
.Fixes #11137