Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master forward-port] Fixed RPMs using artifacts compiled against a too-new version of glibc #11026

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

fheinecke
Copy link
Contributor

This is a forward port of #11008 into master. There are still a couple of issues (namely, this only affects amd64 RPMs and not all architectures), but they should be fixed in a future PR after v9 is released.

build.assets/build-package.sh Outdated Show resolved Hide resolved
build.assets/build-package.sh Outdated Show resolved Hide resolved
build.assets/build-package.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fheinecke Can you address comments here and merge?

Copy link
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the typo that @webvictim commented about

@r0mant
Copy link
Collaborator

r0mant commented Mar 23, 2022

@fheinecke Can you merge this?

@fheinecke fheinecke enabled auto-merge (squash) March 25, 2022 20:10
@fheinecke fheinecke merged commit 1daf7d2 into master Mar 25, 2022
@fheinecke fheinecke deleted the fred/rpm-centos7-fix branch March 25, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants