-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for filter support for cli tools #11012
Conversation
8af1046
to
571dcfc
Compare
953c047
to
92a80cd
Compare
92a80cd
to
1a7469b
Compare
- [Dynamic Impersonation](./access-controls/guides/impersonation/#dynamic-impersonation) | ||
- [RBAC for sessions](./access-controls/reference/#rbac-for-sessions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the predicate language is also used for access requests
, but i could not find documentation on how to define the fields (so i left it out for now). there are mentions of the field here though but with no examples: https://goteleport.com/docs/setup/reference/terraform-provider/#teleport_role,
i'm not sure if these fields are only applicable to terraform provider?
c6562f8
to
9d2a2b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for putting this together!
2b7e292
to
8c133da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some minor suggestions
|
||
| Field | Description | | ||
|---------------------------------------------------|----------------------------------------------------------------| | ||
| `user.spec.traits["<list name>"]` | the `list` of traits from a local or SSO user | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see list
used literally within a configuration resource, so "the list
" might not be the clearest description to use here. Is there another way to phrase this that might be more recognizable? In other words, where would a user know how to find the value to use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, the doc says that user traits typically come from an external identity provider
, so this tells me this value will rarely change, so instead of <list name>
i put the actual value of what it will typically be
8c133da
to
bba724d
Compare
bba724d
to
ca766c4
Compare
For the flags --search, --query, and labels
Description
By
9.1
the cli toolstsh
andtctl
will have filter support. This PR adds docs on how to use the filters.Rendered Doc Links
CLI help
The CLI
--help
has the following minimum instructions (same output for supported resources):