[v7 backport] Standardize ACME instruction details #11009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benarent,
klizhentas,
xinding33 and
zmb3
ptgott
changed the title
ptgott
force-pushed
the
paul.gottschling/9556-v7-bp
branch
from
2485772 to
17ad91e
Compare
zmb3
approved these changes
Mar 10, 2022
ptgott
force-pushed
the
paul.gottschling/9556-v7-bp
branch
2 times, most recently
from
5c706c0 to
11d0543
Compare
russjones
approved these changes
Mar 18, 2022
r0mant
approved these changes
Mar 18, 2022
ptgott
force-pushed
the
paul.gottschling/9556-v7-bp
branch
from
11d0543 to
a1603fe
Compare
ptgott
force-pushed
the
paul.gottschling/9556-v7-bp
branch
2 times, most recently
from
86cea1f to
26210c1
Compare
|
@zmb3 @r0mant After rebasing this just now, I ended up fixing some conflicts, and it turned out that there was some repeated/awkwardly backported information in the Linux Server Getting Started Guide. I've given all of these changes a look, but would you mind giving this another quick glance to make sure nothing bad slipped through? Thanks! |
Backports #9556 * Standardize ACME instruction details Our Getting Started guides often include instructions for configuring Let's Encrypt and ACME before starting Teleport, but not all of these instructions have the same level of detail, and some are missing some context around how Teleport uses ACME and why you need to open port 443 on your Proxy Service host. This change adds an include that spells out these instructions and invokes the include in the appropriate guides. The intention was to include as much relevant information within the guides themselves to prevent the reader from having to navigate to other pages. Closes #6448 * Respond to PR feedback - Substitute "proxy" for "node" where it was incorrectly used - Some small stylistic fixes - Clarify that "teleport configure" does not write the config itself
ptgott
force-pushed
the
paul.gottschling/9556-v7-bp
branch
from
26210c1 to
9b0ffb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #9556
Our Getting Started guides often include instructions for
configuring Let's Encrypt and ACME before starting
Teleport, but not all of these instructions have the same
level of detail, and some are missing some context around
how Teleport uses ACME and why you need to open port 443 on
your Proxy Service host. This change adds an include that
spells out these instructions and invokes the include in the
appropriate guides.
The intention was to include as much relevant information within
the guides themselves to prevent the reader from having to
navigate to other pages.
Closes #6448
itself