Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moderated Sessions improvements #10991

Merged
merged 39 commits into from
Mar 10, 2022
Merged

Moderated Sessions improvements #10991

merged 39 commits into from
Mar 10, 2022

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented Mar 9, 2022 •
edited
Loading

Items addressed:

@xacrimon xacrimon force-pushed the joel/mod-session-fix branch from e43eecb to 7a4e717 Compare March 9, 2022 16:19
@xacrimon xacrimon linked an issue Mar 9, 2022 that may be closed by this pull request
Improve UX for moderated sessions #10818
Closed
@xacrimon xacrimon force-pushed the joel/mod-session-fix branch from 32127f4 to 818d1a2 Compare March 9, 2022 18:04
@r0mant r0mant mentioned this pull request Mar 9, 2022
Closed
38 tasks
@xacrimon xacrimon force-pushed the joel/mod-session-fix branch from 416ddd6 to 372183c Compare March 10, 2022 12:09
@xacrimon xacrimon marked this pull request as ready for review March 10, 2022 12:09
@xacrimon xacrimon requested a review from zmb3 March 10, 2022 12:09
@github-actions github-actions bot added documentation kubernetes-access tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Mar 10, 2022
@xacrimon xacrimon requested a review from espadolini March 10, 2022 13:27
zmb3
zmb3 reviewed Mar 10, 2022
View reviewed changes
lib/auth/session_access.go Outdated Show resolved Hide resolved
lib/auth/session_access.go Outdated Show resolved Hide resolved
lib/auth/session_access.go Outdated Show resolved Hide resolved
lib/client/api.go Outdated Show resolved Hide resolved
lib/srv/sess.go Outdated Show resolved Hide resolved
lib/srv/termmanager.go Show resolved Hide resolved
lib/srv/sess.go Outdated Show resolved Hide resolved
tool/tsh/kube.go Outdated Show resolved Hide resolved
zmb3
zmb3 reviewed Mar 10, 2022
View reviewed changes
constants.go Outdated Show resolved Hide resolved
zmb3
zmb3 reviewed Mar 10, 2022
View reviewed changes
lib/auth/session_access.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from zmb3 March 10, 2022 16:29
zmb3
zmb3 reviewed Mar 10, 2022
View reviewed changes
lib/srv/termmanager.go Outdated Show resolved Hide resolved
@xacrimon xacrimon force-pushed the joel/mod-session-fix branch from 6027414 to 0ef3d04 Compare March 10, 2022 20:29
@xacrimon xacrimon enabled auto-merge (squash) March 10, 2022 21:45
@xacrimon xacrimon merged commit 92543d9 into master Mar 10, 2022
@xacrimon xacrimon deleted the joel/mod-session-fix branch March 10, 2022 23:04
xacrimon added a commit that referenced this pull request Mar 10, 2022
@xacrimon
Moderated Sessions improvements (#10991)
e58210b
@xacrimon xacrimon mentioned this pull request Mar 10, 2022
Merged
r0mant pushed a commit that referenced this pull request Mar 10, 2022
@xacrimon
Moderated Sessions improvements (#10991) (#11051)
428a3ce
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@zmb3 zmb3 zmb3 approved these changes

@espadolini espadolini espadolini approved these changes

@xinding33 xinding33 Awaiting requested review from xinding33

Assignees
No one assigned
Labels
documentation kubernetes-access moderated-sessions tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
5 participants
@xacrimon @r0mant @espadolini @zmb3 @ptgott