Automatically calculate public_addr field for dynamic apps (#10941).
#10943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've dropped the We may want to revisit the naming requirements... but there are other options too: for example, we may simply change the logic by which we calculate the |
Tener
changed the title
public_addr field for dynamic apps (#10941).
probakowski
approved these changes
Mar 11, 2022
|
@r0mant @smallinsky let me know what you think. |
smallinsky
reviewed
Mar 14, 2022
smallinsky
approved these changes
Mar 15, 2022
Tener
added a commit
that referenced
this pull request
Mar 15, 2022
#10943) * Autodiscover public_addr for dynamic apps.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For static apps, the
public_addrfield for app will be discovered automatically if it is missing. For dynamic apps this hasn't been implemented, which breaks some assumptions as well as makes them genuinely less useful.This fixes that, and also adds some minor validation for the dynamic app name for consistency with static apps.
Fixes #10941.