Clean up Rust/Go interop #10915
Merged
Clean up Rust/Go interop #10915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyb89
approved these changes
Mar 7, 2022
zmb3
force-pushed
the
zmb3/rust-memory-leak
branch
from
5e86ce0 to
c010eaf
Compare
Prior to this change, the bitmap data was copied into Go first (via C.GoBytes), converted to RGBA, and then copied a second time into the RBGA image that we pass to the PNG encoder. Instead, use unsafe.Slice to get a slice backed by the Rust-managed memory. Perform the RGBA conversion in-place here, and then perform one copy from the Rust-managed memory into the Go RBGA image.
Pass Go a pointer to the CGOBitmap, otherwise Rust assumes ownership is passing through the FFI and will not free the memory when we're finished with it.
zmb3
force-pushed
the
zmb3/rust-memory-leak
branch
from
c010eaf to
0b37060
Compare
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 changes: