Regenerate server identity if APIDomain not present #10904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallinsky
force-pushed
the
smallinsky/regenerate_identity_on_api_domain
branch
from
f2e0bba to
206f5c9
Compare
smallinsky
requested review from
russjones,
r0mant and
espadolini
and removed request for
gabrielcorado and
zmb3
espadolini
reviewed
Mar 7, 2022
espadolini
reviewed
Mar 7, 2022
espadolini
reviewed
Mar 7, 2022
smallinsky
force-pushed
the
smallinsky/regenerate_identity_on_api_domain
branch
2 times, most recently
from
427f42f to
60f15c5
Compare
r0mant
approved these changes
Mar 7, 2022
espadolini
approved these changes
Mar 8, 2022
This was referenced Mar 8, 2022
smallinsky
force-pushed
the
smallinsky/regenerate_identity_on_api_domain
branch
from
d1548ba to
8ea05b3
Compare
espadolini
approved these changes
Mar 8, 2022
smallinsky
force-pushed
the
smallinsky/regenerate_identity_on_api_domain
branch
from
8ea05b3 to
09fa7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix identity regeneration logic for
KubeRoleIf Kube server identity was generated before teleport 6.3.20 the
APIDomainDNS was not added https://github.com/gravitational/teleport/blob/v6.1.6/lib/auth/auth.go#L1384After teleport is upgrade to newest version the identity is not regenerated because the APIDomain is added on client side but the regeneration check is done based on
getAdditionalPrincipalsresult.This PR updaters the
getAdditionalPrincipalsand return APIDomain DNS to trigger identity regeneration if needed.