-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client cert in insecure mode #10899
Conversation
9f88244
to
a86ea74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a brief description to the PR, but otherwise looks alright.
a86ea74
to
10eef50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's still a bug here. Basically, it looks like getTLSConfigInsecure
now tries to append client cert in all scenarios, not just when connecting to self-hosted databases.
Let's backport to v8 and v9. |
Add client certificate to DB insecure mode.
Add client certificate to DB insecure mode.
Add client certificate to DB insecure mode. Backport of #10899
Add client certificate to DB insecure mode. Backport of #10899
Currently Database Access TLS
insecure
mode doesn't include client certificate when connecting to a database. This change adds client certificate to requests ininsecure
mode.Closes #10803