helm: Add support for separate Postgres/Mongo listeners in teleport-cluster chart #10858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Mar 7, 2022
webvictim
changed the title
|
@zmb3 The scope of the PR has changed a bit now with a couple of new values, so would appreciate a re-review. |
webvictim
commented
Mar 21, 2022
Comment on lines
-15
to
-24
| - it: matches snapshot for acme-off.yaml | ||
| values: | ||
| - ../.lint/acme-off.yaml | ||
| asserts: | ||
| - hasDocuments: | ||
| count: 1 | ||
| - isKind: | ||
| of: ConfigMap | ||
| - matchSnapshot: {} | ||
|
|
There was a problem hiding this comment.
This test was accidentally duplicated twice in the initial commit.
|
@zmb3 This one has unit tests now... 😁 |
webvictim
force-pushed
the
gus/helm/aws-acm
branch
from
7b211d1 to
4f94a12
Compare
zmb3
approved these changes
Mar 23, 2022
r0mant
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
@webvictim Should we add this to the Helm chart docs too in this PR?
|
@r0mant Yes, good point. I will add this to the docs, merge and backport tomorrow. |
Also adds missing example for setitng proxyListenerMode
|
Also adds a quick fix for #11411 |
webvictim
added a commit
that referenced
this pull request
Mar 24, 2022
…luster chart (#10858) * helm: Update NOTES.txt for AWS ACM * Add support for separate Postgres/MongoDB listeners in teleport-cluster chart * Special case backend listener protocol based on presence of ACM annotation * Don't add AWS annotations when not in AWS mode * Adds for separatePostgresListener/separateMongoListener Also adds missing example for setitng proxyListenerMode * Add continuous backups permission to DynamoDB policy Fixes #11411
webvictim
added a commit
that referenced
this pull request
Mar 24, 2022
…luster chart (#10858) * helm: Update NOTES.txt for AWS ACM * Add support for separate Postgres/MongoDB listeners in teleport-cluster chart * Special case backend listener protocol based on presence of ACM annotation * Don't add AWS annotations when not in AWS mode * Adds for separatePostgresListener/separateMongoListener Also adds missing example for setitng proxyListenerMode * Add continuous backups permission to DynamoDB policy
webvictim
added a commit
that referenced
this pull request
Mar 31, 2022
…luster chart (#10858) (#11434) * helm: Update NOTES.txt for AWS ACM * Add support for separate Postgres/MongoDB listeners in teleport-cluster chart * Special case backend listener protocol based on presence of ACM annotation * Don't add AWS annotations when not in AWS mode * Adds for separatePostgresListener/separateMongoListener Also adds missing example for setitng proxyListenerMode * Add continuous backups permission to DynamoDB policy
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for separating Postgres and/or Mongo listeners out to a separate port and configuring the
LoadBalancerappropriately. This is useful when using ACM to terminate traffic in front of the load balancer, as multiplexing on the same port will no longer work.It also adds a special case to
teleport-clusterNOTES.txt when using AWS ACM, so we don't show an error whencert-managerisn't enabled but ACM is being used.Backports required:
branch/v8branch/v9Linked to #10857