-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #9556 to branch/v9 #10824
Merged
Merged
Backport #9556 to branch/v9 #10824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
force-pushed
the
auto-backport/9556-to-branch/v9
branch
from
March 3, 2022 22:54
74d8b90
to
eb5fec4
Compare
zmb3
approved these changes
Mar 3, 2022
r0mant
approved these changes
Mar 4, 2022
ptgott
force-pushed
the
auto-backport/9556-to-branch/v9
branch
from
March 4, 2022 16:18
eb5fec4
to
2177f4a
Compare
Our Getting Started guides often include instructions for configuring Let's Encrypt and ACME before starting Teleport, but not all of these instructions have the same level of detail, and some are missing some context around how Teleport uses ACME and why you need to open port 443 on your Proxy Service host. This change adds an include that spells out these instructions and invokes the include in the appropriate guides. The intention was to include as much relevant information within the guides themselves to prevent the reader from having to navigate to other pages. Closes #6448
- Substitute "proxy" for "node" where it was incorrectly used - Some small stylistic fixes - Clarify that "teleport configure" does not write the config itself
ptgott
force-pushed
the
auto-backport/9556-to-branch/v9
branch
from
March 4, 2022 21:06
2177f4a
to
65c9aba
Compare
ptgott
added a commit
that referenced
this pull request
Mar 9, 2022
start-auth-proxy.mdx is a partial used by a number of Database Access guides. After PR #10824, the partial included garbled instructions for setting up Teleport with Let's Encrypt, the result of resolving cherry- pick conflicts during a backport. This change edits these instructions for clarity.
ptgott
added a commit
that referenced
this pull request
Mar 9, 2022
Backports #11013 start-auth-proxy.mdx is a partial used by a number of Database Access guides. After PR #10824, the partial included garbled instructions for setting up Teleport with Let's Encrypt, the result of resolving cherry- pick conflicts during a backport. This change edits these instructions for clarity.
ptgott
added a commit
that referenced
this pull request
Mar 10, 2022
Backports #11013 start-auth-proxy.mdx is a partial used by a number of Database Access guides. After PR #10824, the partial included garbled instructions for setting up Teleport with Let's Encrypt, the result of resolving cherry- pick conflicts during a backport. This change edits these instructions for clarity.
ptgott
added a commit
that referenced
this pull request
Mar 10, 2022
start-auth-proxy.mdx is a partial used by a number of Database Access guides. After PR #10824, the partial included garbled instructions for setting up Teleport with Let's Encrypt, the result of resolving cherry- pick conflicts during a backport. This change edits these instructions for clarity.
ptgott
added a commit
that referenced
this pull request
Mar 10, 2022
start-auth-proxy.mdx is a partial used by a number of Database Access guides. After PR #10824, the partial included garbled instructions for setting up Teleport with Let's Encrypt, the result of resolving cherry- pick conflicts during a backport. This change edits these instructions for clarity.
ptgott
added a commit
that referenced
this pull request
Mar 10, 2022
Backports #11013 start-auth-proxy.mdx is a partial used by a number of Database Access guides. After PR #10824, the partial included garbled instructions for setting up Teleport with Let's Encrypt, the result of resolving cherry- pick conflicts during a backport. This change edits these instructions for clarity.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9556 to branch/v9