Sort kubernetes cluster #10702
Merged
Sort kubernetes cluster #10702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
requested review from
espadolini and
rosstimothy
and removed request for
alex-kovoy and
gzdunek
kimlisa
force-pushed
the
lisa/sort-kube
branch
2 times, most recently
from
90a54c8 to
f0ac6eb
Compare
rosstimothy
approved these changes
Mar 2, 2022
espadolini
approved these changes
Mar 3, 2022
russjones
approved these changes
Mar 7, 2022
kimlisa
added a commit
that referenced
this pull request
Mar 7, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of RFD 55
Description
Sorting for kube resource is weird in that it has a 1-N relationship (service to many clusters), in order to apply "sort" filter correctly, we need to extract all kube clusters from services into its own list and deduplicated.
So if a user wants to apply sort to kube clusters, they need to request
ListResourceswith typeKindKubernetesClusterthat returns a list of this type. TypeKindKubernetesClustercan only be supported through fake pagination.I contained this feature in the auth layer. It felt weird to include in the presence layer since resources returned there are
keep aliveresources (wasn't sure if this was a right thing to do though)