Better Semaphore Lease Contention Handling #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimbishopp
approved these changes
Mar 1, 2022
Comment on lines
+805
to
+806
| const baseBackoff = time.Millisecond * 300 | ||
| const leaseRetryAttempts int64 = 6 |
There was a problem hiding this comment.
Not sure if it is worth doing now, but it would be nice if these were variables in PresenceService so we could add test coverage for the LimitExceeded error without having to wait 4.5 seconds.
There was a problem hiding this comment.
Yeah I agree. I was trying to limit the noise in this PR though.
Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
rosstimothy
force-pushed
the
tross/semaphore_cancel
branch
from
395ad5b to
e6fce4b
Compare
r0mant
approved these changes
Mar 3, 2022
rosstimothy
added a commit
that referenced
this pull request
Mar 4, 2022
Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
Merged
rosstimothy
added a commit
that referenced
this pull request
Mar 4, 2022
Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
Merged
rosstimothy
added a commit
that referenced
this pull request
Mar 4, 2022
Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
Merged
rosstimothy
added a commit
that referenced
this pull request
Mar 10, 2022
Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
rosstimothy
added a commit
that referenced
this pull request
Mar 10, 2022
Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
rosstimothy
added a commit
that referenced
this pull request
Mar 11, 2022
* Better Semaphore Lease Contention Handling (#10666) Add the same retry logic from `AcquireSemaphore` to `CancelSemaphoreLease` to handle contetion. Without the retry it is possible for a cancellation to fail and the lease in question to remain held for its entire expiry. If the number of cancellations that fail is >= `max_connections` then this causes a user to effectively be locked out until the leases are expired. Fixes #10363
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the same retry logic from
AcquireSemaphoretoCancelSemaphoreLeaseto handle contetion. Without the retry it is possible for a cancellation
to fail and the lease in question to remain held for its entire expiry.
If the number of cancellations that fail is >=
max_connectionsthenthis causes a user to effectively be locked out until the leases are
expired.
Fixes #10363