Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tbot binary in Teleport packages and installs #10646

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

timothyb89
Copy link
Contributor

@timothyb89 timothyb89 commented Feb 25, 2022

This includes the tbot binary in .rpm, .deb, and .pkg distributions, and ensures the binary is installed using the install script in .tar.gz packages.

Will need a backport to v9.

Fixes #10645

This includes the tbot binary in .rpm, .deb, and .pkg distributions,
and ensures the binary is installed using the `install` script in
.tar.gz packages.
@timothyb89
Copy link
Contributor Author

We might want to add a systemd service eventually, but there's some install script work that should probably happen along with that (since the bot should run under its own unix user). At least for the moment, though, we should actually install the binary.

@timothyb89 timothyb89 requested a review from webvictim February 25, 2022 21:07
Copy link
Contributor

@webvictim webvictim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but it's been a while)

@timothyb89 timothyb89 enabled auto-merge (squash) March 1, 2022 22:37
@timothyb89 timothyb89 disabled auto-merge March 1, 2022 23:27
@russjones
Copy link
Contributor

@timothyb89 Looks like this is approved, can you merge?

@timothyb89
Copy link
Contributor Author

It seems to be stuck on "checking reviewers" unfortunately

Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0mant Can you take a look as well?

@timothyb89 timothyb89 enabled auto-merge (squash) March 3, 2022 03:03
@timothyb89 timothyb89 merged commit 6d83fed into master Mar 3, 2022
@timothyb89 timothyb89 deleted the timothyb89/tbot-install branch March 3, 2022 03:25
timothyb89 added a commit that referenced this pull request Mar 3, 2022
* Include tbot binary in Teleport packages and installs

This includes the tbot binary in .rpm, .deb, and .pkg distributions,
and ensures the binary is installed using the `install` script in
.tar.gz packages.

* Remove tbot from macOS client-only builds
timothyb89 added a commit that referenced this pull request Mar 7, 2022
* Include tbot binary in Teleport packages and installs

This includes the tbot binary in .rpm, .deb, and .pkg distributions,
and ensures the binary is installed using the `install` script in
.tar.gz packages.

* Remove tbot from macOS client-only builds
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tbot isn't included in ./install script
5 participants