-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update database guides with database configurator. #10451
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0a08a01
docs: update database guides to use configurator
gabrielcorado d88bc3a
Apply suggestions from code review
gabrielcorado ffc3a65
docs(database): add auto-discovery IAM policies reference
gabrielcorado 389cbed
docs(database): update with code review suggestions
gabrielcorado 5066b54
docs(database): update with review suggestions
gabrielcorado 09b7a7b
Apply suggestions from code review
gabrielcorado 09ff2e0
docs(database): remove H3 lines
gabrielcorado 766191d
docs(database): update auto-discovery reference
gabrielcorado 4299386
docs(database): update policy examples to be more restrictive
gabrielcorado 596f110
Merge branch 'master' into gabrielcorado/db-configurator-docs
gabrielcorado 4c9a2c2
Apply suggestions from code review
gabrielcorado 5601c99
Merge branch 'master' into gabrielcorado/db-configurator-docs
gabrielcorado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When are we using "Database Service" vs "database agent"? Are the two terms interchangeable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure which one we should use or if we can use both. @r0mant, do you have any thoughts on which name is more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, using "database agent" vs. "Database Service" is a docs-wide issue, so we can talk about it a separate issue so we don't block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've been trying to standardize on "Database Service" or "Database Service agent" following @ptgott's lead.