Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: include static_labels in database example #10414

Merged
merged 3 commits into from
Mar 17, 2022
Merged

helm: include static_labels in database example #10414

merged 3 commits into from
Mar 17, 2022

Conversation

Erick-Reyes
Copy link
Contributor

Update clarifying comment for database section.

@Erick-Reyes
Updated comment
18ec7fc 
Update clarifying comment for database section.
@github-actions github-actions bot requested review from r0mant and russjones February 16, 2022 20:15
@github-actions github-actions bot added the helm label Feb 16, 2022
@zmb3 zmb3 changed the title Updated comment helm: include static_labels in database example Feb 16, 2022
zmb3
zmb3 approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but consider a more descriptive commit message so that it's easier to tell what this change is.

webvictim
webvictim requested changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@webvictim webvictim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment inline, I think we should keep maps consistent as we don't use this format anywhere else in the file or our docs.

examples/chart/teleport-kube-agent/values.yaml Outdated Show resolved Hide resolved
@webvictim webvictim enabled auto-merge (squash) March 17, 2022 02:41
@webvictim
Copy link
Contributor

/gcbrun

@webvictim webvictim merged commit 508bf7a into master Mar 17, 2022
@webvictim webvictim deleted the Erick-Reyes/update-values-comment branch March 17, 2022 03:04
webvictim added a commit that referenced this pull request Mar 17, 2022
@Erick-Reyes @webvictim
helm: include static_labels in database example (#10414)
14b8546 
* Updated comment

Update clarifying comment for database section.

* Update examples/chart/teleport-kube-agent/values.yaml

Co-authored-by: Gus Luxton <[email protected]>
@webvictim webvictim mentioned this pull request Mar 17, 2022
Merged
webvictim added a commit that referenced this pull request Mar 17, 2022
@Erick-Reyes @webvictim
helm: include static_labels in database example (#10414)
12a710e 
* Updated comment

Update clarifying comment for database section.

* Update examples/chart/teleport-kube-agent/values.yaml

Co-authored-by: Gus Luxton <[email protected]>
@webvictim webvictim mentioned this pull request Mar 17, 2022
Merged
webvictim added a commit that referenced this pull request Mar 17, 2022
@webvictim @Erick-Reyes
helm: include static_labels in database example (#10414) (#11214)
2f3c7d5 
* Updated comment

Update clarifying comment for database section.

* Update examples/chart/teleport-kube-agent/values.yaml

Co-authored-by: Gus Luxton <[email protected]>

Co-authored-by: Erick Reyes <[email protected]>
webvictim added a commit that referenced this pull request Mar 17, 2022
@webvictim @Erick-Reyes
helm: include static_labels in database example (#10414) (#11213)
f07081d 
* Updated comment

Update clarifying comment for database section.

* Update examples/chart/teleport-kube-agent/values.yaml

Co-authored-by: Gus Luxton <[email protected]>

Co-authored-by: Erick Reyes <[email protected]>
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@russjones russjones russjones approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@webvictim webvictim Awaiting requested review from webvictim

Assignees
No one assigned
Labels
helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erick-Reyes @webvictim @russjones @zmb3