Don't open clipboard static channel when clipboard is disabled #10348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we relied only on the frontend to check whether or not RBAC allows access to the shared clipboard feature. Add a new config parameter, which is passed all the way down do Rust. If the clipboard is not enabled, we will never open the CLIPRDR channel and no clipboard data will be exchanged with the RDP server. This is both more secure and more efficient. We also take care to ensure that clipboard actions that are attempted when the clipboard is disabled is treated as a no-op rather than an error. This ensures that a misbehaving client can't cause us to kill the connection by sending clipboard messages when the shared clipboard is disabled.
zmb3
force-pushed
the
zmb3/clipboard-rbac
branch
from
a29e3df to
5d7defd
Compare
ibeckermayer
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we relied only on the frontend to check whether
or not RBAC allows access to the shared clipboard feature.
Add a new config parameter, which is passed all the way down do Rust.
If the clipboard is not enabled, we will never open the CLIPRDR channel
and no clipboard data will be exchanged with the RDP server. This is
both more secure and more efficient.
We also take care to ensure that clipboard actions that are attempted
when the clipboard is disabled is treated as a no-op rather than an
error. This ensures that a misbehaving client can't cause us to kill
the connection by sending clipboard messages when the shared clipboard
is disabled.