Implement global SessionData storage #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branched from #10281; will target to master once that is in. |
Tener
approved these changes
Feb 11, 2022
rosstimothy
approved these changes
Feb 11, 2022
codingllama
force-pushed
the
codingllama/pwdless-protos
branch
6 times, most recently
from
1fb2e1d to
2d3c278
Compare
codingllama
force-pushed
the
codingllama/pwdless-globalsd
branch
from
f1dc4c3 to
60d238f
Compare
codingllama
force-pushed
the
codingllama/pwdless-globalsd
branch
3 times, most recently
from
a2bd646 to
8a3f67f
Compare
codingllama
force-pushed
the
codingllama/pwdless-globalsd
branch
from
8a3f67f to
222ff3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global session data is used to store passwordless challenges. Per-user session data cannot be used, as the user is now known by the time the challenge is issued.
I elected to keep both global and per-user session data storage for now, as per-user is less subject to DDoS-type attacks than global.
#9160