Clear terminal when auth server is in FIPS mode #10095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
reviewed
Feb 2, 2022
| @@ -373,6 +373,8 @@ message PingResponse { | |||
| Features ServerFeatures = 3 [ (gogoproto.jsontag) = "server_features" ]; | |||
| // ProxyPublicAddr is the server's public proxy address. | |||
| string ProxyPublicAddr = 4 [ (gogoproto.jsontag) = "proxy_public_addr" ]; | |||
| // IsBoring signals whether or not the server was compiled with BoringCrypto. | |||
| bool IsBoring = 5 [ (gogoproto.jsontag) = "is_boring" ]; | |||
There was a problem hiding this comment.
This is not exposed on the public unauth /ping endpoint right?
There was a problem hiding this comment.
Correct. This is only exposed on auth's grpc server.
timothyb89
reviewed
Feb 5, 2022
|
@timothyb89 @lxea Can you take another look at this when you have a moment? |
lxea
approved these changes
Feb 17, 2022
|
@atburke Let's backport this to |
atburke
added a commit
that referenced
this pull request
Feb 23, 2022
This change clears the terminal at the end of a session when the auth server is in FIPS mode, even if tsh isn't.
atburke
added a commit
that referenced
this pull request
Mar 2, 2022
This change clears the terminal at the end of a session when the auth server is in FIPS mode, even if tsh isn't.
Closed
9 tasks
atburke
added a commit
that referenced
this pull request
Sep 14, 2022
This change clears the terminal at the end of a session when the auth server is in FIPS mode, even if tsh isn't.
atburke
added a commit
that referenced
this pull request
Sep 14, 2022
This change clears the terminal at the end of a session when the auth server is in FIPS mode, even if tsh isn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8850. This PR clears the terminal at the end of a session when the auth server is in FIPS mode, even if
tshisn't.Resolves #9767.