Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Access: periodically refresh Windows desktops from LDAP #8644

Closed
zmb3 opened this issue Oct 18, 2021 · 0 comments
Closed

Desktop Access: periodically refresh Windows desktops from LDAP #8644

zmb3 opened this issue Oct 18, 2021 · 0 comments
Assignees
Labels
desktop-access feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@zmb3
Copy link
Collaborator

zmb3 commented Oct 18, 2021

What

In the initial implementation of host discovery, we only search for Windows desktops once on startup. This prevents us from picking up new desktops or timing out desktops that leave the domain.

How

Run the LDAP search query on a configurable interval. Ensure that the heartbeat goroutine produces heartbeats for each of the hosts based on the most recent LDAP search.

Why

In order to keep an accurate list of Windows desktops.

@zmb3 zmb3 added feature-request Used for new features in Teleport, improvements to current should be #enhancements desktop-access labels Oct 18, 2021
@zmb3 zmb3 added this to the 8.1 milestone Oct 18, 2021
@zmb3 zmb3 self-assigned this Oct 18, 2021
@zmb3 zmb3 removed this from the 8.1 milestone Oct 25, 2021
zmb3 added a commit that referenced this issue Nov 27, 2021
zmb3 added a commit that referenced this issue Nov 30, 2021
@zmb3 zmb3 closed this as completed in ce03d2c Dec 2, 2021
zmb3 added a commit that referenced this issue Dec 2, 2021
* Refactor component heartbeat callbacks

Consolidate the OK/degraded broadcasts so the same logic isn't
duplicated for each component.

* Periodically update discovered desktops

Fixes #8644

* Allow customizing the desktop search

With this change, we support a discovery base DN other than '*',
and add support for further filtering the results with additional
LDAP filters.

Additionally, we filter out group managed service accounts, which
show up in LDAP searches for (objectClass=computer), despite not
being comptuers. (This is mostly harmless, as the service accounts
aren't present in DNS, so Teleport just ignores them. It does, however,
log a DNS error message that could be confusing, so we explicitly
filter these out just to be safe. This was discovered when testing
on AWS managed AD, which creates a gMSA for DNS.
zmb3 added a commit that referenced this issue Dec 3, 2021
* Expose endpoint for fetching single desktop (#9041)

* updates endpoints

* Exposes an endpoint for fetching a single desktop by name

* Apply suggestions from code review

Co-authored-by: Zac Bergquist <[email protected]>

* changes inaccurate desktopUUID to desktopName

Co-authored-by: Zac Bergquist <[email protected]>

* docs: LDAP service account setup (#8875)

* updating docs with service account tutorial

* minor corrections

* Apply suggestions from code review

Co-authored-by: Zac Bergquist <[email protected]>

* wording changes based on CR

* minor changes and fixes and adds updated photos with new naming convention

* Updating documentation

* updating gpo instructions to actually make sense

* nits

* adding instructions for exporting ca

* removing unhelpful screen shot

* Fixes quotes and updates to LDAPS

Co-authored-by: Ben Arent <[email protected]>

* clarifying comment

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Ben Arent <[email protected]>

* Enhance LDAP desktop discovery (#9152)

* Refactor component heartbeat callbacks

Consolidate the OK/degraded broadcasts so the same logic isn't
duplicated for each component.

* Periodically update discovered desktops

Fixes #8644

* Allow customizing the desktop search

With this change, we support a discovery base DN other than '*',
and add support for further filtering the results with additional
LDAP filters.

Additionally, we filter out group managed service accounts, which
show up in LDAP searches for (objectClass=computer), despite not
being comptuers. (This is mostly harmless, as the service accounts
aren't present in DNS, so Teleport just ignores them. It does, however,
log a DNS error message that could be confusing, so we explicitly
filter these out just to be safe. This was discovered when testing
on AWS managed AD, which creates a gMSA for DNS.

* simplify connection establishment (#9098)

* Adds username and initial screen size to the websocket parameter string and sends over tdp during the connection process

* simplifications from CR

* fixes // //

* Update e ref

* Create separate builds for CentOS7 (+fips)

Add new buildboxes for centos7 and centos7-fips.

For now, we will continue to support both CentOS 6 and 7.
Eventually we will drop support for CentOS 6, and the only
supported CentOS builds will be these new CentOS 7 builds.

Fixes #9028

* [auto] Update webassets in zmb3/desktop-access-backports (#9210)

444cf33 simplify connection establishment (#480) gravitational/webapps@444cf33

[source: -w teleport-v8] [target: -t zmb3/desktop-access-backports]

Co-authored-by: Isaiah Becker-Mayer <[email protected]>
Co-authored-by: Ben Arent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop-access feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

No branches or pull requests

1 participant