Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 1Password for 'login' #10356

Closed
benarent opened this issue Feb 15, 2022 · 3 comments · Fixed by gravitational/webapps#605
Closed

Disable 1Password for 'login' #10356

benarent opened this issue Feb 15, 2022 · 3 comments · Fixed by gravitational/webapps#605
Labels
bug ux

Comments

@benarent
Copy link
Contributor

Description

What happened:

I noticed a customer run into this issue today. If you try to login to a server, 1Password will try to autofill.

image

What you expected to happen:

Only show logins from Teleport.
@zmb3
Copy link
Collaborator

zmb3 commented Feb 15, 2022

Setting autocomplete="off" on that element should do the trick.

@webvictim
Copy link
Contributor

I've seen this too, it'd be a nice UI fix.

@JonGilmore
Copy link

I've recently been running into this as well, would be nice to fix it as our org does use 1password

zmb3 added a commit to gravitational/webapps that referenced this issue Feb 17, 2022
@zmb3
Disable autocomplete on the SSH login input
07d6829 
This prevents password managers like 1password from attempting to
autocomplete the SSH login, which is not a standard password field.

Fixes gravitational/teleport#10356
@zmb3 zmb3 mentioned this issue Feb 17, 2022
Merged
zmb3 added a commit to gravitational/webapps that referenced this issue Mar 2, 2022
@zmb3 @kimlisa
Disable autocomplete on the SSH login input (#605)
0b6ca8c 
This prevents password managers like 1password from attempting to
autocomplete the SSH login, which is not a standard password field.

Fixes gravitational/teleport#10356

Co-authored-by: Lisa Kim <[email protected]>
zmb3 added a commit to gravitational/webapps that referenced this issue Mar 2, 2022
@zmb3 @kimlisa
Disable autocomplete on the SSH login input (#605)
230eabf 
This prevents password managers like 1password from attempting to
autocomplete the SSH login, which is not a standard password field.

Fixes gravitational/teleport#10356

Co-authored-by: Lisa Kim <[email protected]>
@zmb3 zmb3 mentioned this issue Mar 2, 2022
Merged
kimlisa pushed a commit to gravitational/webapps that referenced this issue Mar 7, 2022
@zmb3
Disable autocomplete on the SSH login input (#605) (#639)
b675634 
This prevents password managers like 1password from attempting to
autocomplete the SSH login, which is not a standard password field.

Fixes gravitational/teleport#10356
hatched pushed a commit to hatched/teleport-merge that referenced this issue Nov 30, 2022
@zmb3 @kimlisa
Disable autocomplete on the SSH login input (gravitational#605)
ee71448 
This prevents password managers like 1password from attempting to
autocomplete the SSH login, which is not a standard password field.

Fixes gravitational#10356

Co-authored-by: Lisa Kim <[email protected]>
hatched pushed a commit that referenced this issue Dec 20, 2022
@zmb3 @kimlisa
Disable autocomplete on the SSH login input (#605)
20f5ff1 
This prevents password managers like 1password from attempting to
autocomplete the SSH login, which is not a standard password field.

Fixes #10356

Co-authored-by: Lisa Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable autocomplete on the SSH login input gravitational/webapps
4 participants
@benarent @webvictim @JonGilmore @zmb3