Fix DB Query always return success false in audit log (#23270)

* Initialize db query to status of success true * Init event status as success true
gravitational · Mar 18, 2023 · b4e1f39 · b4e1f39
1 parent 202a474
commit b4e1f39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/srv/db/common/audit.go b/lib/srv/db/common/audit.go
@@ -134,6 +134,9 @@ func (a *audit) OnQuery(ctx context.Context, session *Session, query Query) {
 		DatabaseMetadata:        MakeDatabaseMetadata(session),
 		DatabaseQuery:           query.Query,
 		DatabaseQueryParameters: query.Parameters,
+		Status: events.Status{
+			Success: true,
+		},
 	}
 	if query.Database != "" {
 		event.DatabaseMetadata.DatabaseName = query.Database

diff --git a/lib/srv/db/sqlserver/engine_test.go b/lib/srv/db/sqlserver/engine_test.go
@@ -125,6 +125,9 @@ func TestHandleConnectionAuditEvents(t *testing.T) {
 						Code: libevents.DatabaseSessionQueryCode,
 					},
 					DatabaseQuery: "\nselect 'foo' as 'bar'\n        ",
+					Status: events.Status{
+						Success: true,
+					},
 				}),
 			},
 		},