-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for remark/rehype plugins #125
Conversation
Amplify deployment status
|
6ef75eb
to
1021c27
Compare
I'm happy to split this one up if it makes it easier to review. Most of the files in this PR are test fixtures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing so LGTM
@avatus Thanks! I've looked into why preview builds are failing, and it might be an issue with the |
1021c27
to
c2c089f
Compare
c2c089f
to
4a322cc
Compare
4a322cc
to
723bbbb
Compare
723bbbb
to
573b52e
Compare
@avatus I've removed the |
573b52e
to
6db499b
Compare
See #17 Migrate unit tests for our custom remark and rehype plugins from the archived `gravitational/docs` repo. Convert these tests to Jest, which unlike the uvu testing tool we used for `gravitational/docs`, is still being maintained. Add a GitHub Actions workflow to run the tests on pull requests. This change does not add tests for `remark-includes`, which requires some changes to how the site processes link paths.
6db499b
to
4a89959
Compare
See #17
Migrate unit tests for our custom remark and rehype plugins from the archived
gravitational/docs
repo. Convert these tests to Jest, which unlike the uvu testing tool we used forgravitational/docs
, is still being maintained. Add a GitHub Actions workflow to run the tests on pull requests.To get the
remark-includes
test to pass, edit theupdatePaths
function to only extract a version number from the path of a partial if the partial falls under a directory path for production content.