This repository was archived by the owner on Feb 8, 2018. It is now read-only.
Improve logic in account closing #4291
Merged
+129
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix bugs in balance checking (`> 0` vs `!= 0`) - allow admins to close accounts w/ balance - refactor test suite a little bit - add tests
|
Ready for review, @mattbk. |
|
Admin sees the following when closing an account with a balance:
|
|
Non-admin participant sees:
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impetus was bugs discovered at #3602 (comment).
> 0vs!= 0)Resolve