Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix CSRF annoyance #4185

Merged
merged 3 commits into from
Nov 14, 2016
Merged

Fix CSRF annoyance #4185

merged 3 commits into from
Nov 14, 2016

Conversation

chadwhitacre
Copy link
Contributor

Redux of #4184 (I couldn't help but close it in the course of gratipay/inside.gratipay.com#884 (comment)).


We're getting a ridiculous number of TypeErrors from trying to constant_time_compare one or two Nones. Sup with that?

@chadwhitacre
Copy link
Contributor Author

Looks like H1-123942 (we serve the entire UI on the assets.gratipay.com subdomain) is potentially implicated. I see this URL in the Sentry report—though Sentry is sampling so who knows if this is truly a factor:

POST /assets/on/openstreetmap/redirect HTTP/1.1,

@rohitpaulk
Copy link
Contributor

@rohitpaulk
Copy link
Contributor

Definitely looks like this is related to Hackerone, looks like a bot is running different combinations of known exploits - every event has a different item in it:

For example:

action=opt-in&then=L2Fzc2V0cy90b3VjaC8/ZXRhZz1xUVF2S05ibGpiSlBhMlVwbWYyZzRnfn4%3d&user_id=&csrf_token='"><svg%2fonload%3d(new(Image)).src%3d'%2f%2fhdyqcl0il5t505ov4g2vf1efr6xxrplf97zvrik69\56burpcollaborator.net

@rohitpaulk rohitpaulk self-assigned this Nov 14, 2016
@rohitpaulk
Copy link
Contributor

Looks good now. Merging

@rohitpaulk rohitpaulk merged commit f610ea2 into master Nov 14, 2016
@rohitpaulk rohitpaulk deleted the fix-csrf-annoyance branch November 14, 2016 14:31
@chadwhitacre
Copy link
Contributor Author

@rohitpaulk I hadn't actually committed a fix here yet. 😜

@chadwhitacre chadwhitacre mentioned this pull request Nov 14, 2016
@rohitpaulk
Copy link
Contributor

Haha, man how did I miss that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants