This repository was archived by the owner on Feb 8, 2018. It is now read-only.
(ignore) Allow admins to search by email #4145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I had some changes that I didn't revert first. |
|
Closing and will redo. |
mattbk
changed the title
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3382.
If you are an admin, search will return users whose email address (in
participants) matches the query. If you are not an admin, you won't notice the functionality (or lack of).One thing I couldn't figure out was how to match partial strings. E.g., searching for
alicereturns both ~user Alice (onusername) and ~user Alice (onemail_address[email protected]), searching foralonly returns Alice onusername. However, for support cases, I don't think this is a huge problem because we have the entire email address to search with (as long as they contact us with the email address in the database).